I'll try to add a small unit test maybe.

In order for me to work, I had to remove and add again the Comments block on the Site Editor, is this a correct behavior?

@c4rl0sbr4v0 , I would expect that, but I know it's not ideal.

I think that happened because the block type was core/comments-query-loop, and that type is only replaced with core/comments on the editor, so you would have to save changes first there in order to update the block.

It should work fine with the old core/post-comments without removing the block, though, as we are unregistering the block type definition and registering a new one with a different render callback (see this). Although, in that case, it would render the fallback version which doesn't add any markup. 😅

Would it make sense to do something similar (I mean the unregister/register thing) for core/comments-query-loop? 🤔

cc: @ockham

Thanks a lot for testing, @c4rl0sbr4v0 and @DAreRodz!

In order for me to work, I had to remove and add again the Comments block on the Site Editor, is this a correct behavior?

Hmm, I didn't really expect that, TBH 🤔

I think that happened because the block type was core/comments-query-loop, and that type is only replaced with core/comments on the editor, so you would have to save changes first there in order to update the block.

Hmm, I'm not sure that's accurate:

1. The Site Editor is supposed to apply legacy block conversions (and deprecations) right upon loading. (I know it didn't seem to do that for a while, but I believe that's fixed per Site Editor: Make Code Editor reflect block conversions #42081.)
2. If Carlos was using Twenty Twenty-Two to test -- that theme uses the Post Comments block (rather than Comments Query Loop).

Is it possible that Gutenberg hadn't finished rebuilding when you were testing this? (Since this is block PHP, it actually has to go through the build step.)

(Going to merge this since it has approval, but happy to continue discussing this!)

Failing e2e tests are unrelated to this PR (and also present in other PRs and trunk; they seem related to the Quote block).

Is it possible that Gutenberg hadn't finished rebuilding when you were testing this? (Since this is block PHP, it actually has to go through the build step.)

It could be, but I'm not pretty sure about that. I was using a TwentyTwo with a core/comments-query-loop from previous tests, I checked by editing some styles, so I wasn't on the deprecated comments version.

Anyway, I will be happy to re-test it in better conditions (that WP was really dirty from previous Comments testing) 😓